Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use UeberauthOidcc as a library #105

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

refactor: use UeberauthOidcc as a library #105

wants to merge 2 commits into from

Conversation

paulswartz
Copy link

@paulswartz paulswartz commented Dec 6, 2023 •
edited
Loading

@yordis not 💯 sure this is what you meant in erlef/oidcc#263, but I gave it a shot anyways.

Other than requiring users to update to Erlang 26 and possibly changing some error messages, this should be backwards compatible with existing Ueberauth.Strategy.Google configurations.

Benefits:

  • native support for security features such as PKCE and nonces
  • less OIDC / OAuth2 specific code to test/maintain

Cons:

  • bumps the minimum Elixir/Erlang versions

@paulswartz paulswartz requested a review from a team as a code owner December 6, 2023 02:42
@paulswartz paulswartz force-pushed the refactor-oidcc branch 2 times, most recently from 6d2b9c4 to d092ef3 Compare December 6, 2023 02:55
@yordis yordis self-requested a review December 6, 2023 14:42
@yordis
Copy link
Member

yordis commented Dec 6, 2023

I love it! I would love to hear @doomspork thoughts as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yordis yordis Awaiting requested review from yordis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulswartz @yordis